Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ” HTTP Response DTO μ •μ˜ #23

Merged
merged 8 commits into from
Jul 13, 2023
Merged

πŸ” HTTP Response DTO μ •μ˜ #23

merged 8 commits into from
Jul 13, 2023

Conversation

w8385
Copy link
Member

@w8385 w8385 commented Jul 13, 2023

μ—…λ°μ΄νŠΈ μœ ν˜•

  • Hot Fix
  • Release
  • Develop
  • Others

μ—…λ°μ΄νŠΈ κ°œμš”

  • Define Response DTO

μ—…λ°μ΄νŠΈ μš”μ•½

  • Response DTO μ •μ˜
  • μ½”λ“œ λ‚΄λΆ€ 파일 및 디렉토리 λΆ„λ₯˜
  • 응닡이 λ°œμƒν•˜λŠ” 상황 μ •μ˜

ν•΄κ²°ν•œ 문제

  • 파일 λΆ„λ₯˜ κΈ°μ€€ ν•¨μˆ˜ -> κΈ°λŠ₯

λ―Έν•΄κ²° 문제

  • 이슈 μ—…μŠˆ

ν…ŒμŠ€νŠΈ

  • μœ λ‹› ν…ŒμŠ€νŠΈ
  • λΉŒλ“œ ν…ŒμŠ€νŠΈ (톡합 ν…ŒμŠ€νŠΈ)
  • 기타 μœ νš¨μ„± ν…ŒμŠ€νŠΈ

μˆ˜μ • 사항 진단

  • μ½”λ“œκ°€ 이 ν”„λ‘œμ νŠΈμ˜ μŠ€νƒ€μΌ 지침을 λ”°λ¦…λ‹ˆλ‹€.
  • μ½”λ“œμ— λŒ€ν•œ 자체 리뷰λ₯Ό μˆ˜ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.
  • λ³€κ²½ 내역에 λŒ€ν•΄ 주석을 μž‘μ„±ν–ˆμŠ΅λ‹ˆλ‹€.
  • ν•΄λ‹Ή PR에 λŒ€ν•œ λ¬Έμ„œλ₯Ό λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
  • κΈ°λŠ₯, μˆ˜μ • 사항, μ΄μŠˆμ— λŒ€ν•œ ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • λ³€κ²½ λ‚΄μš©μ΄ 둜컬 κ°œλ°œν™˜κ²½μ—μ„œμ˜ ν…ŒμŠ€νŠΈλ₯Ό ν†΅κ³Όν–ˆμŠ΅λ‹ˆλ‹€.

@w8385 w8385 merged commit 55be1f3 into dev Jul 13, 2023
@w8385 w8385 deleted the refactor/response-dto branch July 13, 2023 09:53
@w8385 w8385 changed the title πŸ” Clarify Response dto πŸ” HTTP Response DTO μ •μ˜ Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@w8385